Repository navigation
Conversation
This file contains food-related definitions for the Korean locale.
✅ Deploy Preview for fakerjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #4263 +/- ##
=======================================
Coverage 99.14% 99.14%
=======================================
Files 1179 1180 +1
Lines 3976 3977 +1
Branches 723 709 -14
=======================================
+ Hits 3942 3943 +1
Misses 29 29
Partials 5 5
🚀 New features to boost your workflow:
|
ST-DDT
left a comment
There was a problem hiding this comment.
- Are you familiar with KO language?
- Please limit yourself to 1-2 locale PRs at a time, otherwise you may run into merge conflicts
- We currently have little review capacity, so if you know somebody that is familiar with KO, please sk them to review the PR.
There was a problem hiding this comment.
🟡 Changes recommended
Korean food templates use fixed particles that do not match all substituted nouns, producing grammatically incorrect dish names and descriptions.
1 open issue
What changed in this PR
Adds Korean food data to Faker’s ko locale so food generation uses localized values instead of English fallbacks.
Changes:
- Adds ten food datasets covering dish names, templates, ingredients, and related categories.
- Registers the food definitions in the Korean locale.
- Updates the locale character snapshot for the new Korean text.
| File | Description |
|---|---|
test/__snapshots__/locale-data.spec.ts.snap |
Updates the Korean character inventory. |
src/locales/ko/index.ts |
Registers Korean food definitions. |
src/locales/ko/food/vegetable.ts |
Adds vegetable names. |
src/locales/ko/food/spice.ts |
Adds spices and seasonings. |
src/locales/ko/food/meat.ts |
Adds meat and cut names. |
src/locales/ko/food/ingredient.ts |
Adds cooking ingredients. |
src/locales/ko/food/index.ts |
Exports the food definition modules. |
src/locales/ko/food/fruit.ts |
Adds fruit names. |
src/locales/ko/food/ethnic_category.ts |
Adds cuisine categories. |
src/locales/ko/food/dish.ts |
Adds Korean dish names. |
src/locales/ko/food/dish_pattern.ts |
Adds generated dish-name templates. |
src/locales/ko/food/description_pattern.ts |
Adds food-description templates. |
src/locales/ko/food/adjective.ts |
Adds food-related adjectives. |
Review effort: Balanced
…t particles and spacing
|
Hi @ST-DDT, thank you for the feedback and guidance!
|
No problem, glad you liked it.
I've reviewed it and it looks good. Thanks for contributing ❤️ |

What is the reason for this PR?
The
kolocale has nofoodmodule, so calls likefakerKO.food.dish()fall back to English values when generating Korean test data. Thejalocale already ships food data; this PR adds the equivalent dataset forko.What changed
src/locales/ko/food/with 10 definition modules (adjective, description_pattern, dish, dish_pattern, ethnic_category, fruit, ingredient, meat, spice, vegetable) plus its index, registered in thekolocale definition.en/jafood data; entries are sorted by Korean collation.