Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## test/utils/more-constants #4226 +/- ##
============================================================
Coverage ? 99.09%
============================================================
Files ? 1185
Lines ? 3978
Branches ? 708
============================================================
Hits ? 3942
Misses ? 31
Partials ? 5 🚀 New features to boost your workflow:
|
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ST-DDT
force-pushed
the
refactor/randomizer/readonly
branch
from
November 2, 2026 21:42
58ee43b to
8d0408d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of the discussion in #4209 (comment)
Mark the
Randomizerinterface properties as readonly.I also considered only wrapping it inside
FakerCore:Which variant should we use?
RandomizerwithreadonlypropertiesReadonly<Randomizer>inFakerCoreI prefer 1./the current variant, because it represents our expectation for the type and users can easily extend the type to be writeable. From writeable to readable you need to use explicit casts.
ToDo: Write migration guide after the variant has been chosen.