Repository navigation
feat(person)!: default includeGeneric option set to true in sexType() - #4151
Open
gustavoreino wants to merge 16 commits into
Open
gustavoreino wants to merge 16 commits into
gustavoreino wants to merge 16 commits into
Conversation
✅ Deploy Preview for fakerjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
matthewmayer
requested changes
Oct 15, 2026
matthewmayer
requested changes
Oct 15, 2026
matthewmayer
previously approved these changes
Oct 21, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #4151 +/- ##
=======================================
Coverage 99.18% 99.18%
=======================================
Files 1179 1179
Lines 3941 3941
Branches 711 711
=======================================
Hits 3909 3909
Misses 28 28
Partials 4 4
🚀 New features to boost your workflow:
|
Shinigami92
previously approved these changes
Oct 23, 2026
gustavoreino
dismissed stale reviews from matthewmayer and Shinigami92
via
October 27, 2026 22:45
037ec93
Author
|
I adjusted the code to pass the last test necessary, all that's left is the owner's review @matthewmayer @Shinigami92 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To address issue #3694, this PR updates
faker.person.sexType()so thatincludeGenericdefaults totrueinstead offalsewhen no arguments or options are provided.Summary of Changes
personSexTypedefault options to setincludeGeneric = trueinsrc/modules/person/module.tsandsrc/modules/person/sex-type.ts.@defaulttags inpersonmodule definitions.test/modules/image.spec.ts(personPortrait) to allow'generic'in generated image URLs.git,internet,image,location).test/modules/person.spec.tsto test newfaker.person.sexType()default behaviour.Breaking Changes
faker.person.sexType()now returns'female','male', or'generic'by default when called without options.Previous behavior: