Skip to content

fix(number): avoid rounding past inclusive upper bounds #4145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ST-DDT merged 4 commits into from
Oct 24, 2026
Merged

fix(number): avoid rounding past inclusive upper bounds #4145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4124009
fix(number): avoid rounding past inclusive upper bounds
shin4141 Oct 11, 2026
44ed818
test(number): reuse Mersenne maximum in boundary cases
shin4141 Oct 14, 2026
170fa83
test(number): use Mersenne maximum in float bound test
shin4141 Oct 15, 2026
827ba9e
Merge branch 'next' into codex/faker-number-int-bounds
ST-DDT Oct 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/modules/number/int.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,5 +101,5 @@ export function fakeNumberInt(

const real = distributor(fakerCore.randomizer);
const delta = effectiveMax - effectiveMin + 1; // +1 for inclusive max bounds and even distribution
return Math.floor(real * delta + effectiveMin) * multipleOf;
return (Math.floor(real * delta) + effectiveMin) * multipleOf;
}
34 changes: 34 additions & 0 deletions test/modules/number.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,29 @@ describe('number', () => {

expect(results).toEqual([750, 0, 0, 0, 0, 0, 0, 0, 0, 250]);
});

it('should not round past the upper bound with an offset range', () => {
const nearOne = () => MERSENNE_MAX_VALUE;

expect(faker.number.int({ min: 1, max: 2, distributor: nearOne })).toBe(
2
);
expect(
faker.number.int({
min: 10,
max: 101,
multipleOf: 3,
distributor: nearOne,
})
).toBe(99);
expect(
faker.number.int({
min: Number.MAX_SAFE_INTEGER - 1,
max: Number.MAX_SAFE_INTEGER,
distributor: nearOne,
})
).toBe(Number.MAX_SAFE_INTEGER);
});
});

describe('float', () => {
Expand Down Expand Up @@ -363,6 +386,17 @@ describe('number', () => {
expect(results).toEqual([0, 0.5, 1, 1.5]);
});

it('should not round a constrained float past its upper bound', () => {
expect(
faker.number.float({
min: 0.5,
max: 1,
multipleOf: 0.5,
distributor: () => MERSENNE_MAX_VALUE,
})
).toBe(1);
});

it.each(times(100))(
'provides numbers with an exact fractional digits',
() => {
Expand Down
Loading