Skip to content

Misc test/benchmark updates, and Sync for Sender/Reciever#27

Closed
Dr-Emann wants to merge 5 commits into
faern:mainfrom
Dr-Emann:misc_tests
Closed

Misc test/benchmark updates, and Sync for Sender/Reciever#27
Dr-Emann wants to merge 5 commits into
faern:mainfrom
Dr-Emann:misc_tests

Conversation

@Dr-Emann

@Dr-Emann Dr-Emann commented May 30, 2023

Copy link
Copy Markdown

Fixes #8.
Fixes #26.
Relates to #4, since the size of the waker seems to have decreased (looks like the discriminant is able to fit in the niche for a reference).

  • Cleanup benchmarks to avoid creation in every case
  • Use const generics to move code out of macro
  • Upgrade to criterion 0.5 from 0.3
  • Implement Sync for Sender/Receiver

@faern

faern commented Feb 2, 2025

Copy link
Copy Markdown
Owner

Hi! Sorry for the very slow reply. To be frank, I think this slipped my mind primarily since it does so much. I like one PR to do one thing. Here you have basically four PRs.

Some of these things have already been done/should not be done:

@faern

faern commented Feb 2, 2025

Copy link
Copy Markdown
Owner

Thanks for wanting to contribute! But I'll close this for the reasons stated in the previous comment. If there are things you still want to contribute I'm open to discuss those :) And feel free to submit more PRs, focusing on solving a single thing at a time if possible, please.

@faern faern closed this Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can Criterion measure things after doing a per-iteration setup? Implement Sync for Sender + Receiver

2 participants