Misc test/benchmark updates, and Sync for Sender/Reciever#27
Closed
Dr-Emann wants to merge 5 commits into
Closed
Conversation
Owner
|
Hi! Sorry for the very slow reply. To be frank, I think this slipped my mind primarily since it does so much. I like one PR to do one thing. Here you have basically four PRs. Some of these things have already been done/should not be done:
|
Owner
|
Thanks for wanting to contribute! But I'll close this for the reasons stated in the previous comment. If there are things you still want to contribute I'm open to discuss those :) And feel free to submit more PRs, focusing on solving a single thing at a time if possible, please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8.
Fixes #26.
Relates to #4, since the size of the waker seems to have decreased (looks like the discriminant is able to fit in the niche for a reference).