Fix 0.17 image issues introduced in #267 and #270#272
Closed
carlbennett wants to merge 4 commits intofactoriotools:masterfrom
carlbennett:fix-0.17-image-issues
Closed
Fix 0.17 image issues introduced in #267 and #270#272carlbennett wants to merge 4 commits intofactoriotools:masterfrom carlbennett:fix-0.17-image-issues
carlbennett wants to merge 4 commits intofactoriotools:masterfrom
carlbennett:fix-0.17-image-issues
Conversation
This was referenced Jul 5, 2019
Closed
| fi | ||
|
|
||
| if [[ $UPDATE_MODS_ON_START ]]; then | ||
| if [ -z ${UPDATE_MODS_ON_START+x} ]; then # check if it is not set |
Member
There was a problem hiding this comment.
You can go that with ${UPDATE_MODS_ON_START:-} way nicer and in one if.
Member
|
I will probably not merge this as it is cause I don't see a reason why we should make it posix compliant instead of adding ~1.5 MB bash. We are doing more advanced scripts now and most people are used to use advanced features of bash including me. I am a big fan of test and not needing to quote everything and having some more advanced comparisons. I will cherry pick your contribution addition into master later. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tested this and the image now builds successfully and runs version 0.17.54.