Repository navigation
Clarify CommandFunction environment replacement - #1825
Merged
jrapin merged 2 commits intoNov 4, 2026
Merged
Conversation
Contributor
|
thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1781.
The env argument replaces the inherited subprocess environment. The example now makes that explicit and shows how to merge with os.environ to keep PATH and other variables.
Adds a regression test for inherited, replaced and merged environments. No runtime behavior change.
Tested locally: core and local tests, 60 passed, 1 skipped.