Skip to content

fix: gzip development folder archives - #1823

Merged
jrapin merged 1 commit into
facebookincubator:mainfrom
Shubham-Padkonde:fix/gzip-development-archives
Nov 4, 2026
Merged

jrapin merged 1 commit into
facebookincubator:mainfrom
Shubham-Padkonde:fix/gzip-development-archives

Conversation

@Shubham-Padkonde

Copy link
Copy Markdown
Contributor

archive_dev_folders promises a .tar.gz archive but uses TarFile directly, which writes an uncompressed tar file. A gzip-only reader rejects the result with "not a gzip file" even though automatic format detection can hide the mismatch.

Use tarfile.open with w:gz so the output matches its documented format. Regression coverage opens both default and explicitly named outputs in strict r:gz mode and verifies the archived contents.

Validation: both new cases fail before the change; all 12 core utility tests pass afterward. Black, isort, mypy, and pylint pass for the changed files. An earlier full-suite run on the base encountered the existing timing-sensitive test_requeuing failure.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 3, 2026
@jrapin
jrapin merged commit 71ac295 into facebookincubator:main Nov 4, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants