Optionally allow comparison of public keys to validate SSL certificates.#482
Open
kwgithubusername wants to merge 1 commit intofacebookincubator:mainfrom
Open
Optionally allow comparison of public keys to validate SSL certificates.#482kwgithubusername wants to merge 1 commit intofacebookincubator:mainfrom
kwgithubusername wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
Repository owner
removed
the
GH Review: review-needed
label
Nov 7, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any feedback appreciated, especially on
getPublicKeyStringFromData:as I'm not well-versed in OpenSSL. Implementation is referenced from http://stackoverflow.com/a/15728637Similar to
setSR_SSLPinnedCertificates:, this change would allow developers to callsetSR_comparesPublicKeys:onNSMutableURLRequests.