[babel-plugin] Allow -- prefixed keys in defineConsts to preserve user-authored names - #1460
Merged
Merged
Conversation
Similar to defineVars, keys starting with -- now preserve the user-authored name instead of being hashed. This removes the INVALID_CONST_KEY restriction.
mellyeliu
requested review from
ezzak,
necolas,
nmn and
vincentriemer
as code owners
January 22, 2026 06:55
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
workflow: benchmarks/sizeComparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.
|
workflow: benchmarks/perfComparison of performance test results, measured in operations per second. Larger is better.
|
3 tasks
abhakat
pushed a commit
that referenced
this pull request
Feb 6, 2026
…r-authored names (#1460) Similar to defineVars, keys starting with -- now preserve the user-authored name instead of being hashed. This removes the INVALID_CONST_KEY restriction.
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Similar to defineVars, keys starting with -- now preserve the user-authored name instead of being hashed. Mainly for flexibility though it comes with some safety risks.