util: sync xxhash.h with upstream dev for RISC-V RVV#14604
Open
sunyuechi wants to merge 1 commit intofacebook:mainfrom
Open
util: sync xxhash.h with upstream dev for RISC-V RVV#14604sunyuechi wants to merge 1 commit intofacebook:mainfrom
sunyuechi wants to merge 1 commit intofacebook:mainfrom
Conversation
Bump util/xxhash.h from the 0.8.1 snapshot in fd911f9 to Cyan4973/xxHash dev at 668362bb89b7ca00bc37a58a10d37cb811dbe6a9, picking up upstream's RVV dispatch path for XXH3. RocksDB-side namespace/license/clang-format patches are re-applied. Pinned to the dev SHA because no tagged release contains RVV yet. Drop c115eb6 (std::unreachable workaround -- upstream now uses __builtin_unreachable). Drop 90d6138/8e1bd0227 (NULL->nullptr fixups -- replaced by a localized pragma in xxhash.cc). Tested on SG2044 (openEuler 24.03 SP2, gcc 14.2.1), both rv64gc and rv64gcv: hash_test / bloom_test / db_bloom_filter_test all pass. Signed-off-by: Sun Yuechi <sunyuechi@iscas.ac.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump util/xxhash.h from the 0.8.1 snapshot in fd911f9 to Cyan4973/xxHash dev at 668362bb89b7ca00bc37a58a10d37cb811dbe6a9, picking up upstream's RVV dispatch path for XXH3. RocksDB-side namespace/license/clang-format patches are re-applied. Pinned to the dev SHA because no tagged release contains RVV yet.
Drop c115eb6 (std::unreachable workaround -- upstream now uses __builtin_unreachable). Drop 90d6138 8e1bd02 (NULL->nullptr fixups -- replaced by a localized pragma in xxhash.cc).
Tested on SG2044 (openEuler 24.03 SP2, gcc 14.2.1), both rv64gc and rv64gcv: hash_test / bloom_test / db_bloom_filter_test all pass.