ref-04-tags-and-attributes.md. data-* and aria-* attrs not camel-…#7946
Closed
teameh wants to merge 1 commit intofacebook:masterfrom
Closed
ref-04-tags-and-attributes.md. data-* and aria-* attrs not camel-…#7946teameh wants to merge 1 commit intofacebook:masterfrom
data-* and aria-* attrs not camel-…#7946teameh wants to merge 1 commit intofacebook:masterfrom
Conversation
aweary
suggested changes
Oct 12, 2016
Contributor
aweary
left a comment
aweary
left a comment
There was a problem hiding this comment.
Looks good to me with that small nit 👍
| > Note: | ||
| > | ||
| > All attributes are camel-cased and the attributes `class` and `for` are `className` and `htmlFor`, respectively, to match the DOM API specification. | ||
| > All attributes are camel-cased and the attributes `class` and `for` are `className` and `htmlFor`, respectively, to match the DOM API specification. Custom `data-*` and `aria-*` attributes should not be camel-cased. |
Contributor
There was a problem hiding this comment.
Small nit: can you drop the word "Custom"?
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
Author
Done and rebased. |
Collaborator
|
Thanks for the PR! We've been rewriting nearly every doc in #7864 and this was changed to:
I'm sorry that I can't take your PR now that the old doc is gone, but thanks for raising this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMO it's not clear form the docs how I should pass
aria-labelledby.This note about camel-case makes it look like it's also about the
data-*andaria-*attributes while it's not. Users might think they should use it likeariaLabelledByoraria-labelledBywhile they shouldn't. I think this addition makes this more clear.