[DevTools] Fix display of stack frames with anonymous sources

[eps1lon]

I figured we omit <anonymous> intentionally in the ReactCallSite so we might as well omit it when displayed.

Before:
Array.map @ :NaN

After:
Array.map

[eps1lon]

This is mostly a drive-by. 0 is the bottom value when we have no line number so we should omit it entirely.

[hoxyq]

How about displaying something like Array.map @ native? This is aligned with how Chrome displays V8's stacks.

I am not aware of other potential cases where url could be an empty string.

[hoxyq]

Hmm, actually, I think we should extend ReactStackTrace to have boolean isNative instead. Because we already handle it here:

react/packages/react-devtools-shared/src/backend/utils/parseStackTrace.js

Lines 164 to 167 in d256ca0

	} else if (callSite.isNative()) {
	// $FlowFixMe[prop-missing]
	const isAsync = callSite.isAsync();
	result.push([name, '', 0, 0, 0, 0, isAsync]);

And if its native, we should add @ native suffix, else if url is absent, then just don't display it.

[eps1lon]

Sure, we can do that in a follow-up. We'd still want something for anonymous sources. Especially for the cases where we don't have access to structured stack traces.

Chrome isn't consistent with displaying the stacks anyway so it doesn't seem terribly important to be perfectly aligned. The @ format is really just in tracing I think. Printing .stack doesn't use that formatting and use at Array.map (<anonymous>) instead.

[eps1lon]

isNative() is also false for Array.prototype.map for me:

let error

const awaitedFlags = ['one'].map( (param) => {
    error = new Error()
    return 'a'
}
)

Error.prepareStackTrace = (error, structuredStackTrace) => {
    for (const frame of structuredStackTrace) {
        console.log(frame.toString(), frame.isNative())
    }
    return ''
}

error.stack