[compiler][newinference] Update fixtures#33471
Closed
josephsavona wants to merge 3 commits intogh/josephsavona/120/basefrom
Closed
[compiler][newinference] Update fixtures#33471josephsavona wants to merge 3 commits intogh/josephsavona/120/basefrom
josephsavona wants to merge 3 commits intogh/josephsavona/120/basefrom
Conversation
Updates fixtures whose output I've double-checked should change [ghstack-poisoned]
This was referenced Jun 6, 2025
This was referenced Jun 6, 2025
This was referenced Jun 6, 2025
github-actions
bot
added
the
React Core Team
This was referenced Jun 6, 2025
[compiler][newinference] Fixes for transitive function capturing, mutation via property loads
#33430
Closed
josephsavona
commented
Jun 6, 2025
| } | ||
| const context = t2; | ||
|
|
||
| mutate(key); |
Member
Author
There was a problem hiding this comment.
the fact that key was incorrectly used as an object key doesn't mean it isn't a mutable object that can mutate here
Comment on lines
+21
to
+25
| onClick={() => data.get(i) + prop1} | ||
| shouldInvokeFns={true} | ||
| /> | ||
| ); | ||
| i = i + 1; |
Member
Author
There was a problem hiding this comment.
the reassignment is mutating a value captured by jsx, this should have been rejected
Updates fixtures whose output I've double-checked should change [ghstack-poisoned]
Updates fixtures whose output I've double-checked should change [ghstack-poisoned]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Updates fixtures whose output I've double-checked should change