Bundle config: Rename global to hasteFileName in bundle config#28979
Closed
kassens wants to merge 1 commit intofacebook:mainfrom
Closed
Bundle config: Rename global to hasteFileName in bundle config#28979kassens wants to merge 1 commit intofacebook:mainfrom
global to hasteFileName in bundle config#28979kassens wants to merge 1 commit intofacebook:mainfrom
Conversation
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: 0a0a3af...25e6d44 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
The whole bundle config is pretty confusing to me, I took a look and here's a few things that could be simplified. This config is now only used for determining the file name for "haste" style bundles for FB and RN builds. In the past it was also used for UMD builds that we no longer build. Also removes a bunch of parameters to wrappers that were completely unused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundle config: Rename
globaltohasteFileNamein bundle configThe whole bundle config is pretty confusing to me, I took a look and here's a few things that could be simplified.
This config is now only used for determining the file name for "haste" style bundles for FB and RN builds.
In the past it was also used for UMD builds that we no longer build.
Also removes a bunch of parameters to wrappers that were completely unused.