Continue add end-of-frame scheduling for default events #25310
Closed
tyao1 wants to merge 6 commits intofacebook:mainfrom
Closed
Continue add end-of-frame scheduling for default events #25310tyao1 wants to merge 6 commits intofacebook:mainfrom
tyao1 wants to merge 6 commits intofacebook:mainfrom
Conversation
tyao1
force-pushed
the
rh-unknown-lane
branch
from
f4f46dd to
964ff73
Compare
Contributor
Author
tyao1
commented
Oct 5, 2022
|
|
||
| // @gate enableFrameEndScheduling || !allowConcurrentByDefault | ||
| it('When allowConcurrentByDefault is enabled, unknown updates should not be time sliced', () => { | ||
| it.skip('When allowConcurrentByDefault is enabled, unknown updates should not be time sliced', () => { |
Contributor
Author
There was a problem hiding this comment.
I guess we would need to differ default and unknown updates in this case now that default is also rAF, and when update is default and allowConcurrentByDefault is enabled, updates should still be time sliced?
This was referenced Oct 11, 2022
Contributor
Author
|
Resubmitted in #25467 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continue #24594
Added: