Allow to configure hooks to check for async callbacks in eslint-plugin-exhaustive-deps#24958
Allow to configure hooks to check for async callbacks in eslint-plugin-exhaustive-deps#24958ahoisl wants to merge 2 commits intofacebook:mainfrom
Conversation
|
There seem to be (at least) 3 other PRs trying to improve the dependencies parameter index problem, with #24344 seeming to be the most promising (latest & no conflicts). If any of those will be merged, I will gladly remove the "Correct index for hook dependencies" commit from this PR |
|
Any update ? |
ca8670f to
de02be9
Compare
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
|
It's still an issue. Another issue was created that reported a similar problem: #26099 |
Hook dependencies are always the last parameter in a hook call.
Allows to configure which effect hooks to check for async callbacks. Default: `/.*/` (=every checked effect hook)
de02be9 to
9fc0ac7
Compare
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
|
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you! |
|
This is still an issue, but commenting was disallowed, so did not have an option to "bump" |
Summary
checkAsyncForto configure which effect hooks should be checked for async callbacksdependenciesparameter in hooks. Dependencies are usually the last parameter in a hook function, e.g. useImperativeHandleHow did you test this change?