[Test] Outer boundary should not report errors from an inner boundary#24618
Merged
gnoff merged 2 commits intofacebook:mainfrom May 25, 2022
Merged
[Test] Outer boundary should not report errors from an inner boundary#24618gnoff merged 2 commits intofacebook:mainfrom
gnoff merged 2 commits intofacebook:mainfrom
Conversation
acdlite
reviewed
May 25, 2022
Collaborator
Author
|
"this pr is just a test + deleting a bunch of other tests"... 😁 |
…re not retained by an unsuspended outer boundary
gnoff
force-pushed
the
hydration-error-nested-boundaries
branch
from
c26eef1 to
b1fbb14
Compare
|
Comparing: b2763d3...cf2accf Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
Contributor
Collaborator
Author
|
@jplhomer thanks for reporting that issue! It was surprisingly generic (affected flight and fizz) and would have been easy for folks to hit in many different setups |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jplhomer reported an issue with hydration error messages in #24578
The root issue is if you have a pair of nested Suspense boundaries, if the inner one has hydration errors caused by something suspended but the outer one is not suspended, it will report the inner boundaries errors as recoverable.
The changes in #24532 move the recoverable error logic so that it only fires for the hydrating boundary which resolves this bug and causes the test to pass.