feat: add no import expression eslint rule#22507
Closed
headwindz wants to merge 1 commit intofacebook:mainfrom
Closed
feat: add no import expression eslint rule#22507headwindz wants to merge 1 commit intofacebook:mainfrom
headwindz wants to merge 1 commit intofacebook:mainfrom
Conversation
|
Comparing: f2c3811...908ba82 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
c5e66d8 to
908ba82
Compare
crypt096
approved these changes
Oct 12, 2021
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow-up of PR #21918 and issue #21910 . It introduces a custom internal eslint rule to prevent dynamic import expression in literal.
How did you test this change?
yarn testpasses.yarn run eslintpasses.it does report a lint error