Add isArray in devTools utils#22438
Conversation
|
When Sebastian landed this in #21188, he confirmed that the Closure compiler inlines the wrapper function. Unfortunately DevTools doesn't use the same compilation process, and as a result, the wrapper/indirection doesn't get inlined. Maybe longer term, we should look into running Closure compiler over DevTools builds as well– but in the short term, I'm not sure the added benefits from this change are worth the extra wrapper. Maybe we could use a similar approach as |
|
Yes, I agree, I will do it |
|
@bvaughn Done |
|
I'm not sure why CI isn't properly running on your PR. Each time you push, it looks like only the CLA check and Code Sandbox run. |
Yes, this is exactly my question, maybe CI knows me :) |
bvaughn
left a comment
There was a problem hiding this comment.
It's fine. This change seems safe, and I ran the tests locally on your branch. Not sure why CI is not cooperating.
Also here I replaced
Array.isArraywithisArrayfrom 'shared' package