eslint-plugin-react-hooks: support async functions in additional hooks (#19034)#19833
Closed
MichaelBelousov wants to merge 1 commit intofacebook:masterfrom
Closed
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 81a7d4a:
|
facebook#19034) Simply don't warn users about using an async function as the first argument when linting additional hooks, since it is an unfounded restriction to custom dependency-using hooks.
MichaelBelousov
force-pushed
the
allow-async-additional-hooks-with-exhaustive-deps
branch
from
810292c to
81a7d4a
Compare
Author
|
just force pushed the commit with prettier ran over changes |
Author
|
I think this will end up getting closed in favor of #18861 but I'll leave it up until that's resolved |
kbakdev
approved these changes
Oct 23, 2020
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
support async functions in additional hooks (#19034)
Simply don't warn users about using an async function as the first
argument when linting additional hooks, since it is an unfounded
restriction to custom dependency-using hooks.