reference not add to dependencies if only its type is used as typeof arg#19316
Merged
gaearon merged 2 commits intofacebook:masterfrom Jul 13, 2020
Merged
Conversation
delca85
force-pushed
the
remove-typeof-guard-as-hooks-deps
branch
from
42a7e41 to
bbad4b7
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e85dcbe:
|
Member
Contributor
Author
|
Hey @rickhanlonii, actually it should fix it too but I am going to check it as soon as possible! |
gaearon
force-pushed
the
remove-typeof-guard-as-hooks-deps
branch
from
bbad4b7 to
e85dcbe
Compare
Collaborator
|
I'll rebase and get this in. Confirmed it fixes #19327. |
gaearon
approved these changes
Jul 13, 2020
This was referenced Mar 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #18828 .
react-exhaustive-depsdoes not complain anymore about a missing dependency if its value is never used but its type is used astypeofargument.Checking if a reference parent type has type
TSTypeQuery, a reference is not added to dependencies.Test Plan
Added test to check the expected behavior and even that the dependency is required by
react-exhaustive-depsif its type is used and its value too.