Handle legacy root contains in clearContainer#18781
Closed
trueadm wants to merge 2 commits intofacebook:masterfrom
Closed
Handle legacy root contains in clearContainer#18781trueadm wants to merge 2 commits intofacebook:masterfrom
trueadm wants to merge 2 commits intofacebook:masterfrom
Conversation
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4ba1b2f:
|
bvaughn
reviewed
Apr 29, 2020
Collaborator
|
Btw don't forget to update both files. |
Details of bundled changes.Comparing: 88d0be6...4ba1b2f react-dom
Size changes (stable) |
Details of bundled changes.Comparing: 88d0be6...4ba1b2f react-dom
Size changes (experimental) |
Contributor
Author
|
I've updated this PR with another possible fix. I'll leave this PR just to show the changes anyway, but there might be an alternative approach we might want to take instead. |
trueadm
force-pushed
the
fix-root-issue
branch
3 times, most recently
from
aa046af to
fc25111
Compare
Fix Fix Fix Fix
Contributor
|
This PR fixes the regression we're seeing internally. I think there might be a better place to check for this though. Let me post a potential alternate PR here shortly... Edit Potential alternate #18792 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When debugging an internal issue, I noticed that we have an issue where we clear down a root that has existing content. This particular fix checks in
clearContainerif the container we're trying to clear has a legacy container and if it does, checks to see if it matches the root we expected.