[ESLint] Add opt-in support for dangerous autofix#18437
Merged
gaearon merged 1 commit intofacebook:masterfrom Mar 31, 2020
Merged
[ESLint] Add opt-in support for dangerous autofix#18437gaearon merged 1 commit intofacebook:masterfrom
gaearon merged 1 commit intofacebook:masterfrom
Conversation
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 019d926:
|
Details of bundled changes.Comparing: da54641...019d926 eslint-plugin-react-hooks
Size changes (stable) |
Details of bundled changes.Comparing: da54641...019d926 eslint-plugin-react-hooks
Size changes (experimental) |
bvaughn
approved these changes
Mar 31, 2020
This was referenced Mar 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've removed the autofix support from our ESLint rule in 2.4.0 in favor of the new Suggestions API. But some people are asking (#18235, #18099) for autofix. Some IDEs haven't updated yet. Coincidentally, FB's VS Code ESLint extension doesn't support this either. So we can't update the rule internally.
This PR adds an escape hatch. Pass
{ enableDangerousAutofixThisMayCauseInfiniteLoops: true }and you get the old behavior. You've been warned.If you actually apply fix suggestions automatically, you don't want to enable this.