[eslint] strip tailing property in assignments

[Zzzen]

closes #15510

let foo = {}
useEffect(() => {
  foo.bar.baz = 43;
}, []);

This asks you to include foo.bar.baz into deps. But this doesn't make sense, as you write to it. Instead it should ask to include foo.bar into array.

[sizebot]

Details of bundled changes.

Comparing: 45b6443...5ded688

eslint-plugin-react-hooks

File	Filesize Diff	Gzip Diff	Prev Size	Current Size	Prev Gzip	Current Gzip	ENV
eslint-plugin-react-hooks.development.js	+0.6%	+0.4%	75.25 KB	75.68 KB	17.31 KB	17.38 KB	NODE_DEV
eslint-plugin-react-hooks.production.min.js	🔺+0.5%	🔺+0.2%	20.14 KB	20.24 KB	6.9 KB	6.91 KB	NODE_PROD

Generated by 🚫 dangerJS against 5ded688

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution.

[gaearon]

Can you please rebase? We moved to the suggestions API so the test needs tweaks.

[Zzzen]

👌 I'll try this weekend.

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2381833:

Sandbox	Source
great-proskuriakova-soe0l	Configuration

[sizebot]

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 2381833

[sizebot]

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 2381833

[Zzzen]

Moved to the suggestions API. PTAL

[gaearon]

What makes you think it's an assignment in this branch? Can we make it more specific and throw on something unexpected?

[Zzzen]

😅 tryStrippingTrailingPropsInAssigment could have been a better choice. I'm trying to enumerate all cases and confused by a test:

function MyComponent(props) {
  useEffect(() => {
    if (props.foo.onChange) {
      props.foo.onChange();
    }
  }, []);
}

Why is props.foo a proper dependency? Why not props.foo.onChange?

[gaearon]

Just inline in this function into the parent one.

[Zzzen]

👌

[gaearon]

Thanks.