Support disabling interaction tracing for suspense promises

[bvaughn]

If a thrown Promise has the __reactDoNotTraceInteractions attribute, React will not wrapped its callbacks to continue tracing any current interaction(s).

Example usage:

function SomeComponent() {
  try {
    const value = SomeCache.read(/*...*/);
  } catch (maybePromise) {
    if (typeof value === "object" && typeof value.then === "function") {
      maybePromise.__reactDoNotTraceInteractions = true;
    }
    throw maybePromise;
  }
}

[sizebot]

No significant bundle size changes to report.

Generated by 🚫 dangerJS against 434c0e9

[sebmarkbage]

The ping part is a bit weird because it means that means that if we’re only suspended on this promise for the first commit I believe it will decrement and complete the interaction before we commit.

I think this only happens if this also happened to cause a “Delayed” suspended state (bad loading) since otherwise we don’t suspend the commit and it’ll continue until it commits.

However fixing this is tricky since we’d have to keep track of this promise and call it once we commit to detach.

[bvaughn]

The ping part is a bit weird because it means that means that if we’re only suspended on this promise for the first commit I believe it will decrement and complete the interaction before we commit.

Hm... I don't think this is the case, but maybe you can point out what I'm overlooking? We only decrement in finishPendingInteractions, which runs after commit.

Not-wrapping isn't the same as decrementing.

[sebmarkbage]

Another way to put it is, if this is ok, then it should be ok to remove this wrapper in all cases.

Because this ping is only relevant when there is an in progress render. If the in progress render keeps its own interactions alive then we never need this.

[bvaughn]

Hm...yeah, maybe wrapping the ping listener is never necessary.