Expose act() sigil correctly for umd builds#16110
Merged
threepointone merged 1 commit intofacebook:masterfrom Jul 11, 2019
Merged
Expose act() sigil correctly for umd builds#16110threepointone merged 1 commit intofacebook:masterfrom
act() sigil correctly for umd builds#16110threepointone merged 1 commit intofacebook:masterfrom
Conversation
trueadm
approved these changes
Jul 11, 2019
after facebook#16039, act was broken for umd builds. This PR fixes it.
threepointone
force-pushed
the
act-umd-fix
branch
from
5dd6baa to
55a2d63
Compare
|
No significant bundle size changes to report. Generated by 🚫 dangerJS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #16039, act was broken for umd builds. This PR fixes it.
A longer term solution is to have some act sanity tests included in whatever we already do for umd builds (or make something new).