Double-render function components with Hooks in DEV in StrictMode#14643
Merged
gaearon merged 5 commits intofacebook:masterfrom Jan 21, 2019
Merged
Double-render function components with Hooks in DEV in StrictMode#14643gaearon merged 5 commits intofacebook:masterfrom
gaearon merged 5 commits intofacebook:masterfrom
Conversation
TestRenderer is built with strict mode doublerender off. We could change that but I'm not sure we want to. So I'll just flip the flag off for this test.
Details of bundled changes.Comparing: 10a7a5b...ee5cb17 react-dom
react-art
react-native-renderer
react-test-renderer
react-reconciler
Generated by 🚫 dangerJS |
trueadm
approved these changes
Jan 21, 2019
Contributor
trueadm
left a comment
trueadm
left a comment
There was a problem hiding this comment.
Personally, I much prefer this approach. Less risky and also not a breaking change (even if the logic from before was DEV only).
Collaborator
Author
|
I'll merge to unblock the sync. |
gaearon
added a commit
that referenced
this pull request
Jan 21, 2019
…Mode" (#14652) * Revert "Revert "Disallow reading context during useMemo etc" (#14651)" This reverts commit 5fce648. * Revert "Add test coverage for readContext() on the server (#14649)" This reverts commit fe2ecd2. * Revert "Warn about incorrect use of useImperativeHandle() (#14647)" This reverts commit 8f45a7f. * Revert "Disallow reading context during useMemo etc (#14648)" This reverts commit 1fcbd22. * Revert "Warn about refs on lazy function components (#14645)" This reverts commit 2a084f5. * Revert "Fix typo (#14560)" This reverts commit b5a3df6. * Revert "fix typo (#14316)" This reverts commit 9c146e6. * Revert "Mention forwardRef() in <Fn ref={...} /> errors and warnings (#14644)" This reverts commit baa6d40. * Revert "Double-render function components with Hooks in DEV in StrictMode (#14643)" This reverts commit a1414e8.
Contributor
|
Nice compromise, Dan |
Collaborator
Author
|
I already reverted |
Collaborator
Author
|
(Resubmitted in #14654) |
Contributor
|
Hm? This was just a follow up comment from #14639. I just meant the concept of doing the double-rendering only for function components that used hooks. Seems like a nice compromise from double rendering everything. |
Collaborator
Author
|
Just wanted to clarify we haven't actually landed this |
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
…cebook#14643) * Double-render functions in strict mode * Double-invoke first function component render too * Mark TestRendererAsync test as internal and revert changes to it TestRenderer is built with strict mode doublerender off. We could change that but I'm not sure we want to. So I'll just flip the flag off for this test. * Only double-invoke components using Hooks * Revert unintentional change
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
…Mode" (facebook#14652) * Revert "Revert "Disallow reading context during useMemo etc" (facebook#14651)" This reverts commit 5fce648. * Revert "Add test coverage for readContext() on the server (facebook#14649)" This reverts commit fe2ecd2. * Revert "Warn about incorrect use of useImperativeHandle() (facebook#14647)" This reverts commit 8f45a7f. * Revert "Disallow reading context during useMemo etc (facebook#14648)" This reverts commit 1fcbd22. * Revert "Warn about refs on lazy function components (facebook#14645)" This reverts commit 2a084f5. * Revert "Fix typo (facebook#14560)" This reverts commit b5a3df6. * Revert "fix typo (facebook#14316)" This reverts commit 9c146e6. * Revert "Mention forwardRef() in <Fn ref={...} /> errors and warnings (facebook#14644)" This reverts commit baa6d40. * Revert "Double-render function components with Hooks in DEV in StrictMode (facebook#14643)" This reverts commit a1414e8.
n8schloss
pushed a commit
to n8schloss/react
that referenced
this pull request
Jan 31, 2019
…cebook#14643) * Double-render functions in strict mode * Double-invoke first function component render too * Mark TestRendererAsync test as internal and revert changes to it TestRenderer is built with strict mode doublerender off. We could change that but I'm not sure we want to. So I'll just flip the flag off for this test. * Only double-invoke components using Hooks * Revert unintentional change
n8schloss
pushed a commit
to n8schloss/react
that referenced
this pull request
Jan 31, 2019
…Mode" (facebook#14652) * Revert "Revert "Disallow reading context during useMemo etc" (facebook#14651)" This reverts commit 5fce648. * Revert "Add test coverage for readContext() on the server (facebook#14649)" This reverts commit fe2ecd2. * Revert "Warn about incorrect use of useImperativeHandle() (facebook#14647)" This reverts commit 8f45a7f. * Revert "Disallow reading context during useMemo etc (facebook#14648)" This reverts commit 1fcbd22. * Revert "Warn about refs on lazy function components (facebook#14645)" This reverts commit 2a084f5. * Revert "Fix typo (facebook#14560)" This reverts commit b5a3df6. * Revert "fix typo (facebook#14316)" This reverts commit 9c146e6. * Revert "Mention forwardRef() in <Fn ref={...} /> errors and warnings (facebook#14644)" This reverts commit baa6d40. * Revert "Double-render function components with Hooks in DEV in StrictMode (facebook#14643)" This reverts commit a1414e8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #14639. (See last commit.)
Less risky. Would make DEV faster for the stateless case. It's mostly Hooks abuse that we're worried about anyway. Added a test for
useMemo(fn, [])specifically.