Fix regression: Errors not emitted in streams

[voxpelli]

Regression introduced in #14182 resulted in errors no longer being emitted on streams, breaking consumers.

The cause is a faulty implementation of the destroy() method of ReactMarkupReadableStream, which resulted in no error event being thrown even though one expected it.

This patch fixes that + adds tests for the fixes.

[gaearon]

I'm not deeply familiar with Node Readable API but base implementation is function (err, cb) { this.push(null); cb(err); }' so this looks good.

[greaveselliott]

Hi, when will this change be released?

[gaearon]

If you need it urgently you can build React from master and get the fix. I can't give you an exact day — we generally release things when we feel they're stable, and this means giving some time for other changes to shake out. Probably within a few weeks.

[greaveselliott]

Thanks for your response Dan, we’ll build from the commit. Elliott Elliott Greaves

…

Sent from my mobile

On 6 Dec 2018, at 16:07, Dan Abramov ***@***.***> wrote: If you need it urgently you can build React from master and get the fix. I can't give you an exact day — we generally release things when we feel they're stable, and this means giving some time for other changes to shake out. Probably within a few weeks. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[decompil3d]

Fix appears to be in 16.7.0