Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .prettierrc
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,15 @@
"requirePragma": true,
"singleQuote": true,
"trailingComma": "all",
"endOfLine": "lf"
"endOfLine": "lf",
"overrides": [
{
"files": [
"*.js"
],
"options": {
"parser": "hermes"
}
}
]
}
5 changes: 3 additions & 2 deletions jest/preprocessor.js
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,10 @@ module.exports = {
);
},

getCacheKey: (createCacheKeyFunction([
// $FlowFixMe[signature-verification-failure]
getCacheKey: createCacheKeyFunction([
__filename,
require.resolve('metro-react-native-babel-transformer'),
require.resolve('@babel/core/package.json'),
]) /*: any */),
]),
};
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@
"mkdirp": "^0.5.1",
"mock-fs": "^5.1.4",
"prettier": "2.8.8",
"prettier-plugin-hermes-parser": "0.12.1",
"react": "18.2.0",
"react-test-renderer": "18.2.0",
"shelljs": "^0.8.5",
Expand Down
20 changes: 3 additions & 17 deletions packages/react-native/Libraries/Animated/nodes/AnimatedValueXY.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,7 @@ import invariant from 'invariant';
export type AnimatedValueXYConfig = $ReadOnly<{
useNativeDriver: boolean,
}>;
type ValueXYListenerCallback = (value: {
x: number,
y: number,
...
}) => mixed;
type ValueXYListenerCallback = (value: {x: number, y: number, ...}) => mixed;

let _uniqueId = 1;

Expand Down Expand Up @@ -135,11 +131,7 @@ export default class AnimatedValueXY extends AnimatedWithChildren {
* See https://reactnative.dev/docs/animatedvaluexy#resetanimation
*/
resetAnimation(
callback?: (value: {
x: number,
y: number,
...
}) => void,
callback?: (value: {x: number, y: number, ...}) => void,
): void {
this.x.resetAnimation();
this.y.resetAnimation();
Expand All @@ -153,13 +145,7 @@ export default class AnimatedValueXY extends AnimatedWithChildren {
*
* See https://reactnative.dev/docs/animatedvaluexy#stopanimation
*/
stopAnimation(
callback?: (value: {
x: number,
y: number,
...
}) => void,
): void {
stopAnimation(callback?: (value: {x: number, y: number, ...}) => void): void {
this.x.stopAnimation();
this.y.stopAnimation();
callback && callback(this.__getValue());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,18 @@ const ScrollViewStickyHeaderWithForwardedRef: React.AbstractComponent<
clearTimeout(_timer.current);
}
};
}, [nextHeaderLayoutY, measured, layoutHeight, layoutY, scrollViewHeight, scrollAnimatedValue, inverted, offset, animatedValueListener, isFabric]);
}, [
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/react-native/Libraries/Components/ScrollView/ScrollViewStickyHeader.js line 249 – Replace ⏎····nextHeaderLayoutY,⏎····measured,⏎····layoutHeight,⏎····layoutY,⏎····scrollViewHeight,⏎····scrollAnimatedValue,⏎····inverted,⏎····offset,⏎····animatedValueListener,⏎····isFabric,⏎·· with nextHeaderLayoutY,·measured,·layoutHeight,·layoutY,·scrollViewHeight,·scrollAnimatedValue,·inverted,·offset,·animatedValueListener,·isFabric (prettier/prettier)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/react-native/Libraries/Components/ScrollView/ScrollViewStickyHeader.js line 249 – Replace ⏎····nextHeaderLayoutY,⏎····measured,⏎····layoutHeight,⏎····layoutY,⏎····scrollViewHeight,⏎····scrollAnimatedValue,⏎····inverted,⏎····offset,⏎····animatedValueListener,⏎····isFabric,⏎·· with nextHeaderLayoutY,·measured,·layoutHeight,·layoutY,·scrollViewHeight,·scrollAnimatedValue,·inverted,·offset,·animatedValueListener,·isFabric (prettier/prettier)

nextHeaderLayoutY,
measured,
layoutHeight,
layoutY,
scrollViewHeight,
scrollAnimatedValue,
inverted,
offset,
animatedValueListener,
isFabric,
]);

const _onLayout = (event: LayoutEvent) => {
setLayoutY(event.nativeEvent.layout.y);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,10 @@ let hasNativeGenerator;
try {
// If this function was lowered by regenerator-transform, it will try to
// access `global.regeneratorRuntime` which doesn't exist yet and will throw.
hasNativeGenerator = hasNativeConstructor(function* () {},
'GeneratorFunction');
hasNativeGenerator = hasNativeConstructor(
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/react-native/Libraries/Core/setUpRegeneratorRuntime.js line 25 – Delete ⏎···· (prettier/prettier)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/react-native/Libraries/Core/setUpRegeneratorRuntime.js line 25 – Delete ⏎···· (prettier/prettier)

function* () {},
'GeneratorFunction',
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/react-native/Libraries/Core/setUpRegeneratorRuntime.js line 27 – Replace ····'GeneratorFunction',⏎·· with ··'GeneratorFunction' (prettier/prettier)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/react-native/Libraries/Core/setUpRegeneratorRuntime.js line 27 – Replace ····'GeneratorFunction',⏎·· with ··'GeneratorFunction' (prettier/prettier)

);
} catch {
// In this case, we know generators are not provided natively.
hasNativeGenerator = false;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,7 @@ const infoLog = require('../Utilities/infoLog');

type Handler = {
onIterate?: () => void,
onStall: (params: {
lastInterval: number,
busyTime: number,
...
}) => ?string,
onStall: (params: {lastInterval: number, busyTime: number, ...}) => ?string,
...
};

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ const backgroundForLevel = (level: LogLevel) =>
default: 'transparent',
pressed: LogBoxStyle.getFatalDarkColor(),
},
}[level]);
})[level];
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/react-native/Libraries/LogBox/UI/LogBoxInspectorHeader.js line 91 – Replace )[level] with [level]) (prettier/prettier)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/react-native/Libraries/LogBox/UI/LogBoxInspectorHeader.js line 91 – Replace )[level] with [level]) (prettier/prettier)


function LogBoxInspectorHeaderButton(
props: $ReadOnly<{|
Expand Down
8 changes: 4 additions & 4 deletions packages/react-native/cli.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,10 @@ async function main() {
if (latest !== currentVersion) {
const msg = `
${chalk.bold.yellow('WARNING:')} You should run ${chalk.white.bold(
'npx react-native@latest',
)} to ensure you're always using the most current version of the CLI. NPX has cached version (${chalk.bold.yellow(
currentVersion,
)}) != current release (${chalk.bold.green(latest)})
'npx react-native@latest',
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/react-native/cli.js line 59 – Insert ······ (prettier/prettier)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/react-native/cli.js line 59 – Insert ······ (prettier/prettier)

)} to ensure you're always using the most current version of the CLI. NPX has cached version (${chalk.bold.yellow(
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/react-native/cli.js line 60 – Insert ······ (prettier/prettier)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/react-native/cli.js line 60 – Insert ······ (prettier/prettier)

currentVersion,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/react-native/cli.js line 61 – Insert ······ (prettier/prettier)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/react-native/cli.js line 61 – Insert ······ (prettier/prettier)

)}) != current release (${chalk.bold.green(latest)})
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/react-native/cli.js line 62 – Insert ······ (prettier/prettier)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/react-native/cli.js line 62 – Insert ······ (prettier/prettier)

`;
console.warn(msg);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,16 @@ function PointerEventAttributesHoverablePointersTestCase(
testNamePrefix + ' ' + expectedPointerType + ' ' + expectedEventType;

detected_pointertypes[event.nativeEvent.pointerType] = true;
harness.test(({assert_equals}) => {
assert_equals(
eventType,
expectedEventType,
'Event.type should be ' + expectedEventType,
);
}, pointerTestName + "'s type should be " + expectedEventType);
harness.test(
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventAttributesHoverablePointers.js line 70 – Delete ⏎········ (prettier/prettier)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventAttributesHoverablePointers.js line 70 – Delete ⏎········ (prettier/prettier)

({assert_equals}) => {
assert_equals(
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventAttributesHoverablePointers.js line 72 – Replace ·········· with ········ (prettier/prettier)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventAttributesHoverablePointers.js line 72 – Replace ·········· with ········ (prettier/prettier)

eventType,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventAttributesHoverablePointers.js line 73 – Delete ·· (prettier/prettier)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventAttributesHoverablePointers.js line 73 – Delete ·· (prettier/prettier)

expectedEventType,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventAttributesHoverablePointers.js line 74 – Delete ·· (prettier/prettier)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventAttributesHoverablePointers.js line 74 – Delete ·· (prettier/prettier)

'Event.type should be ' + expectedEventType,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventAttributesHoverablePointers.js line 75 – Delete ·· (prettier/prettier)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventAttributesHoverablePointers.js line 75 – Delete ·· (prettier/prettier)

);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventAttributesHoverablePointers.js line 76 – Delete ·· (prettier/prettier)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventAttributesHoverablePointers.js line 76 – Delete ·· (prettier/prettier)

},
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventAttributesHoverablePointers.js line 77 – Replace ··},⏎········pointerTestName·+·"'s·type·should·be·"·+·expectedEventType,⏎······ with },·pointerTestName·+·"'s·type·should·be·"·+·expectedEventType (prettier/prettier)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventAttributesHoverablePointers.js line 77 – Replace ··},⏎········pointerTestName·+·"'s·type·should·be·"·+·expectedEventType,⏎······ with },·pointerTestName·+·"'s·type·should·be·"·+·expectedEventType (prettier/prettier)

pointerTestName + "'s type should be " + expectedEventType,
);

// Test button and buttons
if (eventType === 'pointerdown') {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,16 @@ function PointerEventAttributesNoHoverPointersTestCase(
testNamePrefix + ' ' + expectedPointerType + ' ' + expectedEventType;

detected_pointertypes[event.nativeEvent.pointerType] = true;
harness.test(({assert_equals}) => {
assert_equals(
eventType,
expectedEventType,
'Event.type should be ' + expectedEventType,
);
}, pointerTestName + "'s type should be " + expectedEventType);
harness.test(
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventAttributesNoHoverPointers.js line 69 – Delete ⏎········ (prettier/prettier)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventAttributesNoHoverPointers.js line 69 – Delete ⏎········ (prettier/prettier)

({assert_equals}) => {
assert_equals(
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventAttributesNoHoverPointers.js line 71 – Replace ·········· with ········ (prettier/prettier)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventAttributesNoHoverPointers.js line 71 – Replace ·········· with ········ (prettier/prettier)

eventType,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventAttributesNoHoverPointers.js line 72 – Delete ·· (prettier/prettier)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventAttributesNoHoverPointers.js line 72 – Delete ·· (prettier/prettier)

expectedEventType,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventAttributesNoHoverPointers.js line 73 – Delete ·· (prettier/prettier)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventAttributesNoHoverPointers.js line 73 – Delete ·· (prettier/prettier)

'Event.type should be ' + expectedEventType,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventAttributesNoHoverPointers.js line 74 – Delete ·· (prettier/prettier)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventAttributesNoHoverPointers.js line 74 – Delete ·· (prettier/prettier)

);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventAttributesNoHoverPointers.js line 75 – Delete ·· (prettier/prettier)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventAttributesNoHoverPointers.js line 75 – Delete ·· (prettier/prettier)

},
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventAttributesNoHoverPointers.js line 76 – Replace ··},⏎········pointerTestName·+·"'s·type·should·be·"·+·expectedEventType,⏎······ with },·pointerTestName·+·"'s·type·should·be·"·+·expectedEventType (prettier/prettier)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventAttributesNoHoverPointers.js line 76 – Replace ··},⏎········pointerTestName·+·"'s·type·should·be·"·+·expectedEventType,⏎······ with },·pointerTestName·+·"'s·type·should·be·"·+·expectedEventType (prettier/prettier)

pointerTestName + "'s type should be " + expectedEventType,
);

// Test button and buttons
harness.test(({assert_equals}) => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,23 +62,28 @@ function PointerEventPrimaryTouchPointerTestCase(
expectedOrder[Object.keys(detected_events).length];
detected_events[pointerEventIdentifier] = true;

harness.test(({assert_equals}) => {
assert_equals(
boxLabel,
expectedBoxLabel,
'event should be coming from the correct box',
);
assert_equals(
eventType,
expectedEventType.toLowerCase(),
'event should have the right type',
);
assert_equals(
isPrimary,
expectedIsPrimary,
'event should be correctly primary',
);
}, `${expectedBoxLabel} box's ${expectedEventType} should${!expectedIsPrimary ? ' not' : ''} be marked as the primary pointer`);
harness.test(
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js line 65 – Delete ⏎········ (prettier/prettier)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js line 65 – Delete ⏎········ (prettier/prettier)

({assert_equals}) => {
assert_equals(
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js line 67 – Replace ·········· with ········ (prettier/prettier)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js line 67 – Replace ·········· with ········ (prettier/prettier)

boxLabel,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js line 68 – Delete ·· (prettier/prettier)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js line 68 – Delete ·· (prettier/prettier)

expectedBoxLabel,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js line 69 – Delete ·· (prettier/prettier)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js line 69 – Delete ·· (prettier/prettier)

'event should be coming from the correct box',
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js line 70 – Delete ·· (prettier/prettier)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js line 70 – Delete ·· (prettier/prettier)

);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js line 71 – Delete ·· (prettier/prettier)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js line 71 – Delete ·· (prettier/prettier)

assert_equals(
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js line 72 – Replace ·········· with ········ (prettier/prettier)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js line 72 – Replace ·········· with ········ (prettier/prettier)

eventType,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js line 73 – Delete ·· (prettier/prettier)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js line 73 – Delete ·· (prettier/prettier)

expectedEventType.toLowerCase(),
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js line 74 – Delete ·· (prettier/prettier)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js line 74 – Delete ·· (prettier/prettier)

'event should have the right type',
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js line 75 – Delete ·· (prettier/prettier)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js line 75 – Delete ·· (prettier/prettier)

);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js line 76 – Delete ·· (prettier/prettier)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js line 76 – Delete ·· (prettier/prettier)

assert_equals(
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js line 77 – Replace ·········· with ········ (prettier/prettier)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js line 77 – Replace ·········· with ········ (prettier/prettier)

isPrimary,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js line 78 – Delete ·· (prettier/prettier)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js line 78 – Delete ·· (prettier/prettier)

expectedIsPrimary,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js line 79 – Delete ·· (prettier/prettier)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js line 79 – Delete ·· (prettier/prettier)

'event should be correctly primary',
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js line 80 – Delete ·· (prettier/prettier)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js line 80 – Delete ·· (prettier/prettier)

);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js line 81 – Delete ·· (prettier/prettier)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js line 81 – Delete ·· (prettier/prettier)

},
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js line 82 – Replace ··},⏎········${expectedBoxLabel}·box's·${expectedEventType}·should${⏎··········!expectedIsPrimary·?·'·not'·:·''⏎········}·be·marked·as·the·primary·pointer,⏎······ with },·${expectedBoxLabel}·box's·${expectedEventType}·should${!expectedIsPrimary·?·'·not'·:·''}·be·marked·as·the·primary·pointer`` (prettier/prettier)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js line 82 – Replace ··},⏎········${expectedBoxLabel}·box's·${expectedEventType}·should${⏎··········!expectedIsPrimary·?·'·not'·:·''⏎········}·be·marked·as·the·primary·pointer,⏎······ with },·${expectedBoxLabel}·box's·${expectedEventType}·should${!expectedIsPrimary·?·'·not'·:·''}·be·marked·as·the·primary·pointer`` (prettier/prettier)

`${expectedBoxLabel} box's ${expectedEventType} should${
!expectedIsPrimary ? ' not' : ''
} be marked as the primary pointer`,
);
},
[harness],
);
Expand Down
4 changes: 1 addition & 3 deletions packages/virtualized-lists/Lists/VirtualizedListContext.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,7 @@ type Context = $ReadOnly<{
cellKey: string,
ref: React.ElementRef<VirtualizedList>,
}) => void,
unregisterAsNestedChild: ({
ref: React.ElementRef<VirtualizedList>,
}) => void,
unregisterAsNestedChild: ({ref: React.ElementRef<VirtualizedList>}) => void,
}>;

export const VirtualizedListContext: React.Context<?Context> =
Expand Down
20 changes: 20 additions & 0 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5311,6 +5311,11 @@ hermes-estree@0.12.0:
resolved "https://registry.yarnpkg.com/hermes-estree/-/hermes-estree-0.12.0.tgz#8a289f9aee854854422345e6995a48613bac2ca8"
integrity sha512-+e8xR6SCen0wyAKrMT3UD0ZCCLymKhRgjEB5sS28rKiFir/fXgLoeRilRUssFCILmGHb+OvHDUlhxs0+IEyvQw==

hermes-estree@0.12.1:
version "0.12.1"
resolved "https://registry.yarnpkg.com/hermes-estree/-/hermes-estree-0.12.1.tgz#74901ee351387fecbf3c683c90b1fa7d22f1c6f0"
integrity sha512-IWnP3rEZnuEq64IGM/sNsp+QCQcCAAu5TMallJ7bpUw0YUfk5q6cA7tvBGo/D0kGyo5jASc4Yp/CQCsLSSMfGQ==

hermes-estree@0.8.0:
version "0.8.0"
resolved "https://registry.yarnpkg.com/hermes-estree/-/hermes-estree-0.8.0.tgz#530be27243ca49f008381c1f3e8b18fb26bf9ec0"
Expand All @@ -5323,6 +5328,13 @@ hermes-parser@0.12.0:
dependencies:
hermes-estree "0.12.0"

hermes-parser@0.12.1:
version "0.12.1"
resolved "https://registry.yarnpkg.com/hermes-parser/-/hermes-parser-0.12.1.tgz#e60595f05ecd13026c614ca5d9db2eaefe971301"
integrity sha512-53aep6osCq1GiSIlbe7ltPD9v0GeAUtGlaMhgKexGjePoI66GnalLR5aPeuIZbExBQAb+af/kiXT3yxBweuXUA==
dependencies:
hermes-estree "0.12.1"

hermes-parser@0.8.0:
version "0.8.0"
resolved "https://registry.yarnpkg.com/hermes-parser/-/hermes-parser-0.8.0.tgz#116dceaba32e45b16d6aefb5c4c830eaeba2d257"
Expand Down Expand Up @@ -7589,6 +7601,14 @@ prettier-linter-helpers@^1.0.0:
dependencies:
fast-diff "^1.1.2"

prettier-plugin-hermes-parser@0.12.1:
version "0.12.1"
resolved "https://registry.yarnpkg.com/prettier-plugin-hermes-parser/-/prettier-plugin-hermes-parser-0.12.1.tgz#5c1ec4c18cea9c4b88478fa27f172e3f849b40b6"
integrity sha512-Letp5jjP/lpw/zpqKmtuDytQ2fP5M5dExcdUqIZknOwf+cXLirHaDddxz3gqzUJrpU4WzuaC0x3nfcH1Hi0Tng==
dependencies:
hermes-estree "0.12.1"
hermes-parser "0.12.1"

prettier@2.8.8:
version "2.8.8"
resolved "https://registry.yarnpkg.com/prettier/-/prettier-2.8.8.tgz#e8c5d7e98a4305ffe3de2e1fc4aca1a71c28b1da"
Expand Down