Add testID to NewAppScreen Header Component#31652
Closed
NickGerleman wants to merge 1 commit intofacebook:masterfrom
Closed
Add testID to NewAppScreen Header Component#31652NickGerleman wants to merge 1 commit intofacebook:masterfrom
NickGerleman wants to merge 1 commit intofacebook:masterfrom
Conversation
The RN OSS release process includes manual testing that a new template app can be started under various platforms, JS engines, etc. This should ideally be automated, to help reduce wasted engineer-time, and to allow reliably increasing release velocity. `react-native-windows` does already have tests to create and build template projects across our matrix, but they do not start the app and check for a sane result. Adding a `testID` to the new app screen header gives us something to search for in black-box testing to validate that the app started successfully. This should help catch cases where a sample project in repo has changes not reflected in a newly created template app. Did not manually validate the change, though did check that `ImageBackground` forwards props to `Image`, and that `Image` is aware of `testID` and will forward to the native component.
facebook-github-bot
added
p: Microsoft
Base commit: 47b0be5 |
Base commit: 47b0be5 |
Contributor
|
@p-sun has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
Setito
pushed a commit
to Setito/react-native
that referenced
this pull request
Jul 17, 2021
Summary: The RN OSS release process includes manual testing that a new template app can be started under various platforms, JS engines, etc. This should ideally be automated, to help reduce wasted engineer-time, and to allow reliably increasing release velocity. `react-native-windows` does already have tests to create and build template projects across our matrix, but they do not do any runtime validation on the newly created app. Adding a `testID` to the new app screen header gives us something to search for in black-box testing to validate that the app started successfully. This should help catch cases where a sample project in repo has changes not reflected in a newly created template app. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [Internal] [Added] - Add testID to NewAppScreen Header Component Pull Request resolved: facebook#31652 Test Plan: Did not manually validate the change, though did check that `ImageBackground` forwards props to `Image`, and that `Image` is aware of `testID` and will forward to the native component. Reviewed By: kacieb Differential Revision: D28907197 Pulled By: p-sun fbshipit-source-id: db3974294afba25878383f1955cad37b69d95da3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The RN OSS release process includes manual testing that a new template app can be started under various platforms, JS engines, etc. This should ideally be automated, to help reduce wasted engineer-time, and to allow reliably increasing release velocity.
react-native-windowsdoes already have tests to create and build template projects across our matrix, but they do not do any runtime validation on the newly created app. Adding atestIDto the new app screen header gives us something to search for in black-box testing to validate that the app started successfully. This should help catch cases where a sample project in repo has changes not reflected in a newly created template app.Changelog
[Internal] [Added] - Add testID to NewAppScreen Header Component
Test Plan
Did not manually validate the change, though did check that
ImageBackgroundforwards props toImage, and thatImageis aware oftestIDand will forward to the native component.