fix(cli + tests): Bump metro to 0.66 + fix test manual script#31597
Closed
Titozzz wants to merge 1 commit intofacebook:masterfrom
Closed
fix(cli + tests): Bump metro to 0.66 + fix test manual script#31597Titozzz wants to merge 1 commit intofacebook:masterfrom
Titozzz wants to merge 1 commit intofacebook:masterfrom
Conversation
|
Base commit: 118489f |
kelset
approved these changes
May 26, 2021
38 tasks
Contributor
|
@yungsters has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
|
@yungsters merged this pull request in 0d32aef. |
Titozzz
added a commit
to Titozzz/react-native
that referenced
this pull request
Jun 7, 2021
…ok#31597) Summary: Bumped react-native-community/cli to v6 to update metro to 0.66 to fix fast-refresh issues Also updated the manual test e2e script for easier testing. (using npm install would create a package-lock.json and conflict with yarn.lock) <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [GENERAL] [UPDATE] - updated react-native-community/cli to v6 (hence updating metro to 0.66) Pull Request resolved: facebook#31597 Test Plan: I've tested fast-refresh works with / without hermes Reviewed By: TheSavior Differential Revision: D28852660 Pulled By: yungsters fbshipit-source-id: af338e4dd1d52c62949d71f42773963d89bca9db
Titozzz
added a commit
to Titozzz/react-native
that referenced
this pull request
Jun 7, 2021
…ok#31597) Summary: Bumped react-native-community/cli to v6 to update metro to 0.66 to fix fast-refresh issues Also updated the manual test e2e script for easier testing. (using npm install would create a package-lock.json and conflict with yarn.lock) <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [GENERAL] [UPDATE] - updated react-native-community/cli to v6 (hence updating metro to 0.66) Pull Request resolved: facebook#31597 Test Plan: I've tested fast-refresh works with / without hermes Reviewed By: TheSavior Differential Revision: D28852660 Pulled By: yungsters fbshipit-source-id: af338e4dd1d52c62949d71f42773963d89bca9db
tido64
pushed a commit
that referenced
this pull request
Jun 8, 2021
Summary: Bumped react-native-community/cli to v6 to update metro to 0.66 to fix fast-refresh issues Also updated the manual test e2e script for easier testing. (using npm install would create a package-lock.json and conflict with yarn.lock) <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [GENERAL] [UPDATE] - updated react-native-community/cli to v6 (hence updating metro to 0.66) Pull Request resolved: #31597 Test Plan: I've tested fast-refresh works with / without hermes Reviewed By: TheSavior Differential Revision: D28852660 Pulled By: yungsters fbshipit-source-id: af338e4dd1d52c62949d71f42773963d89bca9db
Setito
pushed a commit
to Setito/react-native
that referenced
this pull request
Jul 17, 2021
…ok#31597) Summary: Bumped react-native-community/cli to v6 to update metro to 0.66 to fix fast-refresh issues Also updated the manual test e2e script for easier testing. (using npm install would create a package-lock.json and conflict with yarn.lock) ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [GENERAL] [UPDATE] - updated react-native-community/cli to v6 (hence updating metro to 0.66) Pull Request resolved: facebook#31597 Test Plan: I've tested fast-refresh works with / without hermes Reviewed By: TheSavior Differential Revision: D28852660 Pulled By: yungsters fbshipit-source-id: af338e4dd1d52c62949d71f42773963d89bca9db
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumped @react-native-community/cli to v6 to update metro to 0.66 to fix fast-refresh issues
Also updated the manual test e2e script for easier testing. (using npm install would create a package-lock.json and conflict with yarn.lock)
Changelog
[DEPENDENCY] [UPDATE] - updated @react-native-community/cli to v6 (hence updating metro to 0.66)
Test Plan
I've tested fast-refresh works with / without hermes