Use Gradle Wrapper 6.6 (-all variant)#29793
Closed
friederbluemle wants to merge 1 commit intofacebook:masterfrom
Closed
Use Gradle Wrapper 6.6 (-all variant)#29793friederbluemle wants to merge 1 commit intofacebook:masterfrom
friederbluemle wants to merge 1 commit intofacebook:masterfrom
Conversation
facebook-github-bot
added
the
CLA Signed
Base commit: cf8368f |
Base commit: cf8368f |
dulmandakh
approved these changes
Aug 28, 2020
Contributor
dulmandakh
left a comment
dulmandakh
left a comment
There was a problem hiding this comment.
@mdvacca please merge
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@mdvacca has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Author
|
Thanks @mdvacca @dulmandakh 👍 |
gengjiawen
approved these changes
Aug 31, 2020
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 2, 2020
Summary: `-all` is the **default** for projects generated by Android Studio, and it provides **additional sources** helpful for debugging. It's also much more likely to already exist on a developer's machine (which has built other Android projects), avoiding additional downloads and saving disk space. `-all` has also been the variant used in `react-native` for all versions prior to 5bc67b6. Follow-up to #29613 ## Changelog [Android] [Changed] - Use Gradle Wrapper 6.6 (-all variant) Pull Request resolved: #29793 Test Plan: No test needed since versions are the same. Reviewed By: fkgozali Differential Revision: D23406546 Pulled By: mdvacca fbshipit-source-id: b74dbbfc0317bccf1940b1e5062d866e50aed28a
Collaborator
|
This pull request was successfully merged by @friederbluemle in 3a8559b. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-allis the default for projects generated by Android Studio, and it provides additional sources helpful for debugging. It's also much more likely to already exist on a developer's machine (which has built other Android projects), avoiding additional downloads and saving disk space.-allhas also been the variant used inreact-nativefor all versions prior to 5bc67b6.Follow-up to #29613
Changelog
[Android] [Changed] - Use Gradle Wrapper 6.6 (-all variant)
Test Plan
No test needed since versions are the same.