[lexical] Bug Fix: Clamp DOM selection offsets to valid lexical TextNode offsets in $internalResolveSelectionPoint - #7725
Merged
Conversation
…ode offsets in $internalResolveSelectionPoint
etrepum
requested review from
Fetz,
Sahejkm,
acywatson,
fantactuka,
ivailop7,
lilshady,
potatowagon,
takuyakanbr and
zurfyx
as code owners
July 24, 2025 16:51
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
etrepum
added
extended-tests
facebook-github-bot
added
the
CLA Signed
zurfyx
approved these changes
Jul 24, 2025
This was referenced Jun 27, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In some scenarios when IME input is happening, the browser's Text node will have a selection or content that is not represented in the lexical TextNode (a trailing zero-width-space). This changes the
$internalResolveSelectionPointimplementation such that it will only resolve valid offsets by clamping to the size of the TextNode.There were also scenarios where the MutationObserver handles text mutations without updating the lexical selection, so a similar fix was applied to
flushMutationsCloses #7715 (superseded by this PR)
Closes #7639
Test plan
e2e tests pass, added new e2e test to exercise flushMutations edge cases