[lexical-react] feat: Context Menu icons - #7697
Merged
Merged
Conversation
ivailop7
requested review from
Fetz,
Sahejkm,
acywatson,
fantactuka,
lilshady,
potatowagon,
takuyakanbr and
zurfyx
as code owners
July 16, 2025 21:12
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
meta-cla
Bot
added
the
CLA Signed
etrepum
previously approved these changes
Jul 16, 2025
Collaborator
There was a problem hiding this comment.
Visually the layout in the playground feels a bit unbalanced, maybe because the margin-right of the icon is 10px and the padding-right of the text is 8px but that's just a playground nit
(edit: code looks good and is a useful addition, so approved, up to you if you want to merge as-is or tweak layout)
Collaborator
Author
|
I'll prettify it a bit more |
ivailop7
enabled auto-merge
July 19, 2025 21:17
Collaborator
Author
|
@etrepum can I get a reapproval |
etrepum
approved these changes
Jul 21, 2025
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for icons in the new floatingUI-based context menu (LexicalNodeContextMenu).