Repository navigation
[lexical-playground] fix: close link popup when user clicks out of it - #7670
Merged
Merged
Conversation
achaljhawar
requested review from
Fetz,
Sahejkm,
acywatson,
fantactuka,
ivailop7,
lilshady,
potatowagon,
takuyakanbr and
zurfyx
as code owners
July 3, 2025 17:43
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
etrepum
previously approved these changes
Jul 3, 2025
Co-authored-by: Bob Ippolito <bob@redivi.com>
etrepum
reviewed
Jul 3, 2025
etrepum
left a comment
etrepum
left a comment
Collaborator
There was a problem hiding this comment.
This fails the formatting check, npm run prettier:fix should address that
etrepum
approved these changes
Jul 3, 2025
Merged
fantactuka
pushed a commit
that referenced
this pull request
Aug 11, 2025
…#7670) Co-authored-by: Bob Ippolito <bob@redivi.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a event listener to the FloatingLinkEditor component to ensure the link popup closes when it loses focus.
Closes #7665
Test plan
Before
Lexical.Playground.6.mp4
After
Lexical.Playground.7.mp4