Repository navigation
[lexical] Bug Fix: Workarounds in $config protocol for loose inheritance - #7659
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
etrepum
commented
Jun 30, 2025
| if (!hasOwn(klass, 'importDOM') && hasOwn(klass, 'exportDOM')) { | ||
| if ( | ||
| !hasOwnStaticMethod(klass, 'importDOM') && | ||
| hasOwnExportDOM(klass) |
Collaborator
Author
There was a problem hiding this comment.
This warning wasn't even working before because it was checking the class rather than the prototype 🤦
etrepum
commented
Jun 30, 2025
| } | ||
| if ($isDecoratorNode(proto)) { | ||
| if (!hasOwn(proto, 'decorate')) { | ||
| if (proto.decorate === DecoratorNode.prototype.decorate) { |
Collaborator
Author
There was a problem hiding this comment.
I think this one can be weak since it might make sense in some scenarios to subclass a DecoratorNode but not override its decorate method
etrepum
marked this pull request as ready for review
June 30, 2025 16:06
etrepum
requested review from
Fetz,
Sahejkm,
acywatson,
fantactuka,
ivailop7,
lilshady,
potatowagon,
takuyakanbr and
zurfyx
as code owners
June 30, 2025 16:06
zurfyx
approved these changes
Jun 30, 2025
lilshady
reviewed
Jul 1, 2025
| // TextNode.length > 0 will only be true if the compiler output | ||
| // is not ES6 compliant, in which case we can not provide this | ||
| // warning | ||
| if (__DEV__ && TextNode.length === 0) { |
This was referenced Jul 3, 2025
Merged
fantactuka
pushed a commit
that referenced
this pull request
Aug 11, 2025
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Workarounds for #7258 combined with loose inheritance (not compliant with ES6)
Test plan
Can't really test this in-repo very easily since lexical is built as ES6