Repository navigation
[lexical-table] Bug Fix: Fix table selection for touch devices - #7656
Merged
Merged
Conversation
circlingthesun
requested review from
Fetz,
Sahejkm,
acywatson,
fantactuka,
ivailop7,
lilshady,
potatowagon,
takuyakanbr and
zurfyx
as code owners
June 27, 2025 11:24
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
circlingthesun
force-pushed
the
fix-table-select
branch
from
June 27, 2025 19:37
de49bcd to
c9098b5
Compare
circlingthesun
force-pushed
the
fix-table-select
branch
from
June 27, 2025 19:38
c9098b5 to
de49bcd
Compare
Collaborator
|
I think this is probably closer to the ideal behavior but scrolling removes the selection and with this scheme it's not possible to select more than a screen full of the table since it doesn't scroll internally with the selection ScreenRecording_07-02-2025.16-56-02_1.mov |
Contributor
Author
|
@etrepum this behaviour also happens on the current playground version: ScreenRecording_07-03-2025.16-52-52_1.mov |
etrepum
approved these changes
Jul 3, 2025
etrepum
left a comment
etrepum
left a comment
Collaborator
There was a problem hiding this comment.
Seems to be a net improvement although there are still cases here where it's not very usable, particularly related to scrolling
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently tapping on cell in a table on mobile while the selection is in another cell creates a cell selection, this change ensures that it only happens when dragging.
Closes #7650