Repository navigation
[lexical-table] Bug Fix: Ignore SELECTION_INSERT_CLIPBOARD_NODES_COMMAND dispatched from child editors - #7637
Merged
Conversation
…AND dispatched from child editors
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
etrepum
added
extended-tests
facebook-github-bot
added
the
CLA Signed
|
Thank you so much for this PR and attention to this matter! |
etrepum
marked this pull request as ready for review
June 23, 2025 00:58
etrepum
requested review from
Fetz,
Sahejkm,
acywatson,
fantactuka,
ivailop7,
lilshady,
potatowagon,
takuyakanbr and
zurfyx
as code owners
June 23, 2025 00:58
etrepum
marked this pull request as draft
June 23, 2025 02:52
etrepum
marked this pull request as ready for review
June 23, 2025 15:39
etrepum
marked this pull request as draft
June 23, 2025 15:50
etrepum
marked this pull request as ready for review
June 23, 2025 17:15
ivailop7
approved these changes
Jun 24, 2025
|
Thank you for this. Any idea when a new release will be published? |
Collaborator
Author
|
Nightly releases are published every weekday. Other releases are generally once a month, will be soon. |
Merged
fantactuka
pushed a commit
that referenced
this pull request
Aug 11, 2025
…AND dispatched from child editors (#7637)
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Minimal fix for
SELECTION_INSERT_CLIPBOARD_NODES_COMMANDcommand listeners to prevent parent editor from breaking when content is pasted into a nested editor.See #7635 (comment) for full discussion of the root cause and more complete ways to avoid this type of problem.
Separately, as a follow-up, it would make sense to also address the issue in lexical's error handling that doesn't manage to get the editor into a working state after this error is encountered.
Closes #7635
Test plan
Added an e2e test to demonstrate that the parent editor is still responsive to edits after editing and clearing an image caption then pasting into the caption. Confirmed that this test fails if the bug fix commit is not applied.