Repository navigation
[lexical] Fix: ctrl+a doesn't work well in plain text mode on Firefox - #7579
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
wataru-chocola
marked this pull request as ready for review
May 29, 2025 02:06
wataru-chocola
requested review from
Fetz,
Sahejkm,
acywatson,
fantactuka,
ivailop7,
lilshady,
potatowagon,
takuyakanbr and
zurfyx
as code owners
May 29, 2025 02:06
wataru-chocola
force-pushed
the
fix_select_all_on_firefox
branch
from
May 29, 2025 08:24
7c611e5 to
fefb2df
Compare
Contributor
Author
|
Fixed test cases. I skipped |
etrepum
reviewed
May 29, 2025
etrepum
left a comment
etrepum
left a comment
Collaborator
There was a problem hiding this comment.
I don't think skipping the tests is the best approach, especially because it means that the tests don't cover what you're trying to fix here
wataru-chocola
force-pushed
the
fix_select_all_on_firefox
branch
from
May 30, 2025 00:01
fefb2df to
b5f08be
Compare
Contributor
Author
You are right. |
Merged
fantactuka
pushed a commit
that referenced
this pull request
Aug 11, 2025
…#7579) Co-authored-by: Bob Ippolito <bob@redivi.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enable override of selectall introduced by #4671 for Firefox.
Closes #7578
Test plan
Before
After