[lexical-list] Bug Fix: Removed the hardcoded checkbox width in checklist onclick helper - #7559
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@etrepum i cant merge the PR, please help |
|
Approval runs additional tests, merging doesn't happen immediately or automatically. I'm going to wait to merge this one until #7558 is reviewed because I think it may solve this as well as some other issues and if it works well then that PR would be preferable. |
|
Okay while his fixes for the size of the checkbox seem fine to me, changes in https://github.com/facebook/lexical/pull/7558/files#diff-983bb36964538460466250f740f52fa2bb1d6e7f3d650157748b5eae0159bff0 Also i dont see extended tests running |
|
The extended checks have already run and passed. Sorry, I don't sit at my computer waiting for CI to pass so I can immediately merge changes. |
|
Thanks, no i just saw few of them were skipped, apologies if it came out in a different way, i'm new to this |
…list onclick helper (#7559)
Description
The checkbox onclick handler currently assumes the checkbox size to be 20px, which works for current scenarios as the checkbox doesnt grow with the font size.
instead of hardcoding the checkbox width, now we're using the calculated width of the checkbox
Test plan
Before
Screen.Recording.2025-05-22.at.11.12.57.AM.mov
After
Screen.Recording.2025-05-22.at.11.13.45.AM.mov