Skip to content

[lexical-list] Bug Fix: Removed the hardcoded checkbox width in checklist onclick helper - #7559

Merged
etrepum merged 1 commit into
facebook:mainfrom
jvithlani:jv_checklist
May 22, 2025
Merged

etrepum merged 1 commit into
facebook:mainfrom
jvithlani:jv_checklist

Conversation

@jvithlani

@jvithlani jvithlani commented May 22, 2025 •

Copy link
Copy Markdown
Contributor

Description

The checkbox onclick handler currently assumes the checkbox size to be 20px, which works for current scenarios as the checkbox doesnt grow with the font size.

instead of hardcoding the checkbox width, now we're using the calculated width of the checkbox

Test plan

Before

Screen.Recording.2025-05-22.at.11.12.57.AM.mov

After

Screen.Recording.2025-05-22.at.11.13.45.AM.mov

@vercel

vercel Bot commented May 22, 2025 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2025 5:02am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2025 5:02am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 22, 2025
@etrepum etrepum added the extended-tests Run extended e2e tests on a PR label May 22, 2025
@jvithlani

Copy link
Copy Markdown
Contributor Author

@etrepum i cant merge the PR, please help

@etrepum

etrepum commented May 22, 2025

Copy link
Copy Markdown
Collaborator

Approval runs additional tests, merging doesn't happen immediately or automatically. I'm going to wait to merge this one until #7558 is reviewed because I think it may solve this as well as some other issues and if it works well then that PR would be preferable.

@jvithlani

Copy link
Copy Markdown
Contributor Author

Okay while his fixes for the size of the checkbox seem fine to me, changes in https://github.com/facebook/lexical/pull/7558/files#diff-983bb36964538460466250f740f52fa2bb1d6e7f3d650157748b5eae0159bff0
look over-engineered, hence i've raised this PR, once my PR is merged, those changes in that PR wont be needed.

Also i dont see extended tests running

@etrepum

etrepum commented May 22, 2025

Copy link
Copy Markdown
Collaborator

The extended checks have already run and passed. Sorry, I don't sit at my computer waiting for CI to pass so I can immediately merge changes.

@etrepum
etrepum added this pull request to the merge queue May 22, 2025
Merged via the queue into facebook:main with commit b61a1ea May 22, 2025
@jvithlani

Copy link
Copy Markdown
Contributor Author

Thanks, no i just saw few of them were skipped, apologies if it came out in a different way, i'm new to this

fantactuka pushed a commit that referenced this pull request Aug 11, 2025

This branch was successfully deployed

2 active deployments
Preview – lexical-playground — d2147f47 Deployed May 22, 2025 by vercel[bot]
Preview – lexical — d2147f47 Deployed May 22, 2025 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants