[java] Fix BufferOverrun FP on String.split with non-positive limit - #2094
Merged
Merged
Conversation
The two-arg model used the limit as the result array's malloc size, so split(",", -1) was reported as a possibly negative allocation.
Contributor
|
ERROR 'Running test: direct java performance test' |
…odel The two-arg String.split model now sizes the result from the receiver string, so the loop cost tracks s.length rather than limit.
Contributor
Author
Fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String.split(regex, limit)was modeled by treatinglimitas the malloc size of the result array. Fors.split(",", -1)that producesINFERBO_ALLOC_MAY_BE_NEGATIVEwith length[-1, 1], even though the result length is never negative.Size the result from the receiver (same idea as the one-arg overload). A positive
limitis only used as an upper bound.Fixes #1971