Fix CodeQL C++ issues#2178
Closed
marlenecota wants to merge 1 commit into
Closed
Conversation
chrisglein
reviewed
Apr 24, 2024
chrisglein
left a comment
chrisglein
left a comment
There was a problem hiding this comment.
Don't have access to officially mark "approve", but this change looks good to me.
Contributor
|
@Orvid has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
Author
|
@Orvid - the windows build seems to be failing trying to build boost (before it gets to folly / these changes). Could it be re-run? |
Contributor
|
I don't see a way to manually re-run it on the github side, but this built without errors on our internal Windows build, so should be good to go once the internal pull request is reviewed. |
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
May 16, 2024
Summary: CodeQL found some issues via static analysis. See microsoft/react-native-windows#12703 X-link: facebook/folly#2178 Reviewed By: ilvokhin Differential Revision: D56591460 Pulled By: Orvid fbshipit-source-id: a0af3171a4076ff1131baf6ee53a40ade55667d3
Contributor
Contributor
|
This pull request has been reverted by bbc1773. |
This was referenced May 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeQL found some issues via static analysis. See microsoft/react-native-windows#12703