Skip to content

[Cisco][G200/G202x] Device watermark test fixes for G200/G202x#1062

Open
itskittycisco wants to merge 1 commit intofacebook:mainfrom
itskittycisco:agent_device_watermark
Open

[Cisco][G200/G202x] Device watermark test fixes for G200/G202x#1062
itskittycisco wants to merge 1 commit intofacebook:mainfrom
itskittycisco:agent_device_watermark

Conversation

@itskittycisco
Copy link
Copy Markdown

Pre-submission checklist

  • I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • pre-commit run
    clang-format.............................................................Passed
    shellcheck...........................................(no files to check)Skipped
    shfmt................................................(no files to check)Skipped
    trim trailing whitespace.................................................Passed
    fix end of files.........................................................Passed
    check yaml...........................................(no files to check)Skipped
    check json...........................................(no files to check)Skipped
    check for merge conflicts................................................Passed
    ruff check...........................................(no files to check)Skipped
    ruff format..........................................(no files to check)Skipped

Summary

  1. G200/G202x/Q200 supports SAI_BUFFER_POOL_STAT_WATERMARK_BYTES. The test validates this after sending traffic.
  2. After the port flap, it is expected to have a min buffer and hence add a minimum buffer value for G200/G202x. Q200 already had a check with min buffer value.
  3. Exclude counter check for buffer_watermark_device.p100.60 that is not applicable for G200/G202x/Q200.

Test Plan

Verified running the test manually - AgentWatermarkTest.VerifyDeviceWatermark

@itskittycisco itskittycisco requested a review from a team as a code owner April 3, 2026 18:09
@meta-cla meta-cla bot added the CLA Signed label Apr 3, 2026
@github-actions github-actions bot added the cisco label Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant