[Accton][wedge800bact] fix exception in AgentNeighborResolutionOverFlowTest.neig…#1050
Open
brandonchen-accton wants to merge 1 commit intofacebook:mainfrom
Open
Conversation
…borResolutionOverFlow
brandonchen-accton
changed the title
brandonchen-accton
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a CHECK failure in AgentMacLearningAndNeighborResolutionTests.cpp:610 where hwAsic->getMaxNdpTableSize() returned std::nullopt.
Updated the return value to 8192 to match the actual hardware NDP table capacity, allowing AgentNeighborResolutionOverFlowTest to run successfully.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runTest Plan
[ OK ] warm_boot.AgentNeighborResolutionOverFlowTest.neighborResolutionOverFlow (10355 ms)
[----------] 1 test from AgentNeighborResolutionOverFlowTest (10355 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (10355 ms total)
[ PASSED ] 1 test.
Running all tests took 0:00:20.908446 between 2026-03-30 14:14:54.940537 and 2026-03-30 14:15:15.848983
[ OK ] warm_boot.AgentNeighborResolutionOverFlowTest.neighborResolutionOverFlow (10355 ms)
Summary:
OK : 1
FAILED : 0
SKIPPED : 0
TIMEOUT : 0