[Accton][minipack3n] Update optics SI settings for front ports#1043
Open
jcyu-accton wants to merge 1 commit intofacebook:mainfrom
Open
[Accton][minipack3n] Update optics SI settings for front ports#1043jcyu-accton wants to merge 1 commit intofacebook:mainfrom
jcyu-accton wants to merge 1 commit intofacebook:mainfrom
Conversation
Description:This PR updates the optic SI settings for front ports based on measurements conducted by the SI team.
Changes include:
1.CSV files:Updated SI setting CSV files.
A. 100000 BACKPLANE, Ports=[1:16, 49:64] (pre3, pre2, pre1, main, post1, post2, post3) = (0, 1, -11, 51, 0, x, x), tx_driver = (55)
B. 100000 BACKPLANE, Ports=[17:48] (pre3, pre2, pre1, main, post1, post2, post3) = (0, 1, -10, 52, 0, x, x), tx_driver = (55)
2. Updated platform mapping JSON file for Minipack3N.
3. Updated PlatformMapping.cpp with corrected JSON format for Minipack3N.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:This PR updates the optic SI settings for front ports based on measurements conducted by the SI team.
Changes include:
Updated SI setting CSV files.
A. 100000 BACKPLANE, Ports=[1:16, 49:64] (pre3, pre2, pre1, main, post1, post2, post3) = (0, 1, -11, 51, 0, x, x), tx_driver = (55)
B. 100000 BACKPLANE, Ports=[17:48] (pre3, pre2, pre1, main, post1, post2, post3) = (0, 1, -10, 52, 0, x, x), tx_driver = (55)
Updated platform mapping JSON file for Minipack3N.
Updated PlatformMapping.cpp with corrected JSON format for Minipack3N.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runpre-commit run --files fboss/lib/platform_mapping_v2/generated_platform_mappings/minipack3n_platform_mapping.json
pre-commit run --files fboss/lib/platform_mapping_v2/platforms/minipack3n/minipack3n_si_settings.csv
pre-commit run --files fboss/agent/platforms/common/minipack3n/Minipack3NPlatformMapping.cpp
Summary
Test Plan
Link Test (T0) was run, producing the same results as the baseline configuration (before update SI Value).