[Nexthop] Add BGP thrift definitions#1038
Open
manoharan-nexthop wants to merge 1 commit intofacebook:mainfrom
Open
[Nexthop] Add BGP thrift definitions#1038manoharan-nexthop wants to merge 1 commit intofacebook:mainfrom
manoharan-nexthop wants to merge 1 commit intofacebook:mainfrom
Conversation
manoharan-nexthop
changed the title
adityameta
reviewed
Apr 10, 2026
induvsuresh
reviewed
Apr 16, 2026
induvsuresh
reviewed
Apr 16, 2026
induvsuresh
reviewed
Apr 16, 2026
induvsuresh
reviewed
Apr 16, 2026
induvsuresh
left a comment
induvsuresh
left a comment
There was a problem hiding this comment.
Thank you for the changes, overall lgtm! pls address the inline comments
This commit adds the thrift interface definitions for BGP (Border Gateway Protocol) functionality. These thrift files define the data structures and service interfaces needed for BGP operations. Thrift Files Added: - fboss/bgp/if/bgp_attr.thrift - BGP attribute definitions - fboss/bgp/if/bgp_config.thrift - BGP configuration structures - fboss/bgp/if/bgp_thrift.thrift - Main BGP service interface - fboss/bgp_policy/if/bgp_policy.thrift - BGP policy types - fboss/bgp_policy/if/rib_policy.thrift - RIB policy definitions - fboss/routing/if/vip_service_config.thrift - Virtual IP service config - fboss/routing/policy/if/policy_thrift.thrift - Routing policy definitions - fboss/cli/fboss2/commands/show/bgp/summary/bgp_summary.thrift - BGP summary types Build System Updates: - CMakeLists.txt - Added thrift compilation targets for all BGP thrift files - BUCK files - Added thrift library definitions for Meta-internal builds The thrift files define: - BGP state machine states and peer information - Route attributes (AS path, communities, next hop, etc.) - BGP configuration structures - Policy and filtering definitions - Service interface for BGP operations These definitions will be used by the BGP CLI commands and BGP service implementation.
manoharan-nexthop
force-pushed
the
manoharan.bgp-show-thrift
branch
from
f7abcb4 to
09c95df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
Adds the thrift interface definitions for BGP (Border Gateway Protocol) functionality. These thrift files define the data structures and service interfaces needed for BGP operations.
Thrift Files Added:
Build System Updates:
Test Plan