[Accton][wedge800bact] Add PLATFORM_WEDGE800BACT to ProdConfigFactory#1024
Open
brandonchen-accton wants to merge 1 commit intofacebook:mainfrom
Open
[Accton][wedge800bact] Add PLATFORM_WEDGE800BACT to ProdConfigFactory#1024brandonchen-accton wants to merge 1 commit intofacebook:mainfrom
brandonchen-accton wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: PLATFORM_WEDGE800BACT (platformType 41) was missing from the test utility functions in ProdConfigFactory.cpp. This caused HwProdInvariantsFswStrictPriorityTest.verifyInvariants to throw an exception in the sai_test-sai_impl with: "provided PlatformType: 41 has not been defined for uplinksCountFromSwitch" PLATFORM_WEDGE800BACT has 16 uplinks when operating at 800G, so we added the corresponding definition to fix the test failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PLATFORM_WEDGE800BACT (platformType 41) was missing from the test utility functions in ProdConfigFactory.cpp. This caused HwProdInvariantsFswStrictPriorityTest.verifyInvariants to throw an exception in the sai_test-sai_impl with: "provided PlatformType: 41 has not been defined for uplinksCountFromSwitch"
PLATFORM_WEDGE800BACT has 16 uplinks when operating at 800G, so we added the corresponding definition to fix the test failure.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runTest Plan
[ OK ] HwProdInvariantsFswStrictPriorityTest.verifyInvariants (42435 ms)
[----------] 1 test from HwProdInvariantsFswStrictPriorityTest (42435 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (42435 ms total)
[ PASSED ] 1 test.