Skip to content

docs: add guide to keep title of caution admonitions#9695

Merged
slorber merged 1 commit into
facebook:mainfrom
tats-u:rewrite-caution
Jan 4, 2024
Merged

docs: add guide to keep title of caution admonitions#9695
slorber merged 1 commit into
facebook:mainfrom
tats-u:rewrite-caution

Conversation

@tats-u

@tats-u tats-u commented Jan 4, 2024

Copy link
Copy Markdown
Contributor

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

There are some use cases where “warning” is too strong. This PR provides how to refactor :::caution with its title kept as is.

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

#9307

@tats-u tats-u requested a review from slorber as a code owner January 4, 2024 09:56
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 4, 2024
@netlify

netlify Bot commented Jan 4, 2024

Copy link
Copy Markdown

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 976f07b
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/659680edc7fe570008f1faf5
😎 Deploy Preview https://deploy-preview-9695--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions

github-actions Bot commented Jan 4, 2024

Copy link
Copy Markdown

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 73 🟢 98 🟢 100 🟢 100 🟠 89 Report
/docs/installation 🟠 87 🟢 98 🟢 100 🟢 100 🟠 89 Report
/docs/category/getting-started 🟠 75 🟢 100 🟢 100 🟢 90 🟠 89 Report
/blog 🟠 74 🟢 100 🟢 100 🟢 90 🟠 89 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 64 🟢 97 🟢 100 🟢 100 🟠 89 Report
/blog/tags/release 🟠 70 🟢 100 🟢 100 🟠 80 🟠 89 Report
/blog/tags 🟠 77 🟢 100 🟢 100 🟢 90 🟠 89 Report

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Jan 4, 2024
@slorber

slorber commented Jan 4, 2024

Copy link
Copy Markdown
Collaborator

thanks 👍

@slorber slorber merged commit 332a466 into facebook:main Jan 4, 2024
@tats-u tats-u deleted the rewrite-caution branch January 4, 2024 10:20
tats-u added a commit to tats-u/docusaurus that referenced this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants