refactor: use TS project references instead of running tsc multiple times#7437
Merged
Conversation
Josh-Cena
added
the
pr: maintenance
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Josh-Cena
force-pushed
the
jc/project-references
branch
from
7cc472a to
f48068e
Compare
|
Size Change: -11 kB (-1%) Total Size: 796 kB
ℹ️ View Unchanged
|
This was referenced May 18, 2022
Collaborator
|
great 👍 didn't know about those refs |
mrizwanashiq
pushed a commit
to mrizwanashiq/docusaurus
that referenced
this pull request
Jun 25, 2026
…imes (facebook#7437) * refactor: use TS project references instead of running tsc multiple times * deduplicate * dedup * eliminate --project * add swc config * add target
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
We're finally doing it the right way™
Using a single tsconfig.json means the editor is able to provide the right hints since the root tsconfig.json controls everything. It also means faster type-checking, and better integration with external tools (that are unaware of our custom tsconfig files).
Test Plan
I've checked the build output and made sure the output is still correct.
Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs